Skip to content

Update Go dependencies#12215

Merged
frouioui merged 6 commits intovitessio:mainfrom
planetscale:dbussink/update-go-dependencies
Feb 3, 2023
Merged

Update Go dependencies#12215
frouioui merged 6 commits intovitessio:mainfrom
planetscale:dbussink/update-go-dependencies

Conversation

@dbussink
Copy link
Member

@dbussink dbussink commented Feb 2, 2023

This updates the Go dependencies to the latest versions before the Vitess 16 freeze so we can start with an up to date list.

Also updates vitess-mixin since Dependabot is reporting a bunch of things on that.

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Documentation was added or is not required

@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels Feb 2, 2023
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Feb 2, 2023 •
edited by frouioui
Loading

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a test is added or modified, there should be a documentation on top of the test to explain what the expected behavior is what the test does.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@dbussink dbussink removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels Feb 2, 2023
@dbussink
Update Go dependencies
d39c1fc 
This updates the Go dependencies to the latest versions before the
Vitess 16 freeze so we can start with an up to date list.

Also updates vitess-mixin since Dependabot is reporting a bunch of
things on that.

Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
@dbussink dbussink force-pushed the dbussink/update-go-dependencies branch from 2cd5aae to d39c1fc Compare February 2, 2023 15:35
@frouioui frouioui mentioned this pull request Feb 2, 2023
Closed
35 tasks
@frouioui
Copy link
Member

frouioui commented Feb 2, 2023

Thank you @dbussink 🙇🏻

@dbussink
Fix deprecated sets.String
3b38302 
This is now available using generics.

Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
@frouioui
Merge remote-tracking branch 'origin/main' into dbussink/update-go-de…
cb00c50 
…pendencies

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui
run make proto
bbf9154 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui
Merge remote-tracking branch 'origin/main' into dbussink/update-go-de…
b7b3790 
…pendencies

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui
fix e2e test expectations
3f49c27 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui frouioui merged commit e596c1d into vitessio:main Feb 3, 2023
@frouioui frouioui deleted the dbussink/update-go-dependencies branch February 3, 2023 00:28
timvaillancourt pushed a commit to slackhq/vitess that referenced this pull request May 29, 2024
@dbussink @frouioui @timvaillancourt
Update Go dependencies (vitessio#12215)
79d8785 
* Update Go dependencies

This updates the Go dependencies to the latest versions before the
Vitess 16 freeze so we can start with an up to date list.

Also updates vitess-mixin since Dependabot is reporting a bunch of
things on that.

Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>

* Fix deprecated sets.String

This is now available using generics.

Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>

* run make proto

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* fix e2e test expectations

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

---------

Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>
@timvaillancourt timvaillancourt mentioned this pull request May 29, 2024
Closed
4 tasks
timvaillancourt added a commit to slackhq/vitess that referenced this pull request May 29, 2024
@timvaillancourt
Revert "Update Go dependencies (vitessio#12215)"
c005649 
This reverts commit 79d8785.
This was referenced May 29, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@frouioui frouioui frouioui approved these changes

@ajm188 ajm188 Awaiting requested review from ajm188

@deepthi deepthi Awaiting requested review from deepthi

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal is a code owner

@mattlord mattlord Awaiting requested review from mattlord mattlord is a code owner

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps rohit-nayak-ps is a code owner

@systay systay Awaiting requested review from systay systay is a code owner

@rsajwani rsajwani Awaiting requested review from rsajwani

@shlomi-noach shlomi-noach Awaiting requested review from shlomi-noach shlomi-noach is a code owner

@notfelineit notfelineit Awaiting requested review from notfelineit

+1 more reviewer

@GuptaManan100 GuptaManan100 GuptaManan100 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Component: Build/CI Type: CI/Build

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dbussink @frouioui @GuptaManan100